fix(overlay): error when trying to add/remove empty string class #14919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
overlay-empty-class
branch
from
67729cc to
5f6d112
Compare
jelbourn
reviewed
Jun 25, 2019
src/cdk/overlay/overlay-ref.ts
Outdated
| @@ -471,7 +471,10 @@ export class OverlayRef implements PortalOutlet, OverlayReference { | |||
|
|
|||
| coerceArray(cssClasses).forEach(cssClass => { | |||
| // We can't do a spread here, because IE doesn't support setting multiple classes. | |||
| isAdd ? classList.add(cssClass) : classList.remove(cssClass); | |||
| // Also trying to add an empty string to a DOMTokenList will throw. | |||
| if (cssClass !== '') { | |||
There was a problem hiding this comment.
Could this just be if (cssClass)?
There was a problem hiding this comment.
It's super edge-case-ey, but it would technically exclude a class called false.
There was a problem hiding this comment.
I don't believe that's true; the string 'false' is truthy
There was a problem hiding this comment.
I mean somebody passing in false as a boolean.
There was a problem hiding this comment.
I would actually expect doing nothing in that case over adding a 'false' CSS class
Fixes an error being thrown if an empty string is passed as one of the values to `addPanelClass` or `removePanelClass`.
crisbeto
force-pushed
the
overlay-empty-class
branch
from
5f6d112 to
176c4cf
Compare
mmalerba
pushed a commit
that referenced
this pull request
Oct 8, 2019
Fixes an error being thrown if an empty string is passed as one of the values to `addPanelClass` or `removePanelClass`. (cherry picked from commit 5509c23)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error being thrown if an empty string is passed as one of the values to
addPanelClassorremovePanelClass.