build: avoid 404 warnings in Karma tests #15136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
approved these changes
Feb 9, 2019
devversion
added
pr: lgtm
action: merge
jelbourn
reviewed
Feb 11, 2019
| @@ -42,7 +42,7 @@ describe('MatIcon', () => { | |||
| let fakePath: string; | |||
|
|
|||
| beforeEach(async(() => { | |||
| fakePath = '/fake-path'; | |||
| fakePath = '/$fake-path'; | |||
There was a problem hiding this comment.
Add a comment here that explains the $?
|
Poke @crisbeto I just had the small comment nit before this is merge-ready |
Adds some logic to the Karma config in order to prevent 404s from being logged from some of the tests that need to reference images. Fixes angular#15113.
crisbeto
force-pushed
the
15113/spec-404
branch
from
a8974d8 to
edd51fc
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some logic to the Karma config in order to prevent 404s from being logged from some of the tests that need to reference images.
Fixes #15113.