Skip to content

feat(drag-drop): add the ability to customize how the position is constrained #15137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 9, 2019

Adds the constrainPosition function that allows people to hook into the logic that constrains the position of the element as it's being dragged and to customize it.

Fixes #15055.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Feb 9, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2019
@crisbeto crisbeto force-pushed the 15055/drag-drop-custom-constrain branch from 729005e to 5571f7f Compare February 9, 2019 18:42
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 20, 2019
@jelbourn
Copy link
Member

@crisbeto passes presubmit, just needs rebase

…strained

Adds the `constrainPosition` function that allows people to hook into the logic that constrains the position of the element as it's being dragged and to customize it.

Fixes angular#15055.
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the 15055/drag-drop-custom-constrain branch from 5571f7f to ef96cc1 Compare February 23, 2019 08:21
@josephperrott josephperrott merged commit 4704653 into angular:master Mar 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdkDragMoved prevent move
4 participants