fix(docs): Icon examples aria labels added #15013 #15145
Conversation
googlebot
added
the
cla: yes
| @@ -1 +1 @@ | |||
| <mat-icon svgIcon="thumbs-up"></mat-icon> | |||
| <mat-icon svgIcon="thumbs-up" aria-hidden="false" aria-label="Example thumbs up svg icon"></mat-icon> | |||
There was a problem hiding this comment.
nit: SVG should be upper-cased.
| @@ -1 +1 @@ | |||
| <mat-icon>home</mat-icon> | |||
| <mat-icon aria-hidden="false" aria-label="Example home icon">home</mat-icon> | |||
There was a problem hiding this comment.
I believe that the right thing here is to still keep it as aria-hidden. cc @jelbourn
There was a problem hiding this comment.
This one is somewhat tricky. The icon by itself doesn't actually mean anything since it's just an example. The two options would be to do this (hidden="false" with a label), or to add a separate visibly-hidden span that describes the example.
I think this PR is probably fine as is- it's at least better than what it was before.
jelbourn
added
pr: lgtm
Accessibility
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #15013