Skip to content

fix(docs): Menu button in example is missing an accessible name #15039 #15146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2019
Merged

fix(docs): Menu button in example is missing an accessible name #15039 #15146

merged 3 commits into from
Feb 22, 2019

Conversation

Suresh918
Copy link
Contributor

Fixes #15039

@Suresh918 Suresh918 requested a review from jelbourn as a code owner February 11, 2019 17:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 11, 2019
jelbourn
jelbourn reviewed Feb 13, 2019
View reviewed changes
src/material-examples/menu-icons/menu-icons-example.html Outdated
@@ -1,4 +1,4 @@
<button mat-icon-button [matMenuTriggerFor]="menu">
<button mat-icon-button [matMenuTriggerFor]="menu" aria-label="Example icon">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be

Example icon-button with a menu

Copy link
Contributor Author

@Suresh918 Suresh918 Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn , "menu button" is getting appended by default, so that the complete label becomes "example icon menu button". I tested that. If I give label as "example icon- button with a menu", then it will become "example icon-button with a menu menu button" ? Is there any way to disable those default labels so that we can give complete labels in aria-label itself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing what you're hearing is the screen-reader describing the element. If that's the case, it would still be appropriate to include the whole Example icon-button with a menu would still be appropriate because it's explaining the content separately from what the control is.

jelbourn
jelbourn approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Feb 20, 2019
@jelbourn jelbourn merged commit edb7835 into angular:master Feb 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu button in example is missing an accessible name
3 participants
@Suresh918 @jelbourn @googlebot