fix(sort): remove arrow when sort header is disabled #15212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
approved these changes
Feb 19, 2019
src/lib/sort/sort-header.ts
Outdated
| @@ -289,4 +289,9 @@ export class MatSortHeader extends _MatSortHeaderMixinBase | |||
|
|
|||
| return this._sort.direction == 'asc' ? 'ascending' : 'descending'; | |||
| } | |||
|
|
|||
| /** Gets whether the arrow inside the sort header should be rendered. */ | |||
There was a problem hiding this comment.
Minor nit: Remove the "Gets" and just have "Whether the arrow..."
Doesn't render the arrow for a disabled header, unless it is the active one. This prevents it from taking up space when it won't be used. Fixes angular#14986.
crisbeto
force-pushed
the
14986/hide-sort-header
branch
from
4eb7a54 to
d99c9fe
Compare
josephperrott
pushed a commit
that referenced
this pull request
Mar 6, 2019
Doesn't render the arrow for a disabled header, unless it is the active one. This prevents it from taking up space when it won't be used. Fixes #14986.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't render the arrow for a disabled header, unless it is the active one. This prevents it from taking up space when it won't be used.
Fixes #14986.