docs: adjust element spacing within examples #15369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Mar 2, 2019
| @@ -4,3 +4,10 @@ | |||
| margin: 10px; | |||
| border: 1px solid #555; | |||
| } | |||
|
|
|||
| mat-drawer-content { | |||
| padding: 10px; | |||
There was a problem hiding this comment.
A little nitpicky, but if I remember correctly, all the spacings in the Material design spec were in 4px increments. Maybe we should switch all of these 10px values to 8px or 12px?
There was a problem hiding this comment.
@crisbeto I switched all values to either 12px or 8px. Thanks
* Adjusts the amount of spacing between crowded UI elements in the following examples: button-toggle-appearance, datepicker-api, datepicker-color, datepicker-locale, datepicker-value, expansion-steps, focus-monitor-directives, focus-monitor-focus-via, focus-monitor-overview, form-field-label, input-form, paginator-configurable, sidenav-backdrop, snack-bar-overview, snack-bar-position, text-field-autofill-directive, text-field-autofill-monitor, text-field-autosize-textarea
swseverance
force-pushed
the
fix-examples-styling
branch
from
223ea48 to
2985ef9
Compare
crisbeto
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Mar 4, 2019
* Adjusts the amount of spacing between crowded UI elements in the following examples: button-toggle-appearance, datepicker-api, datepicker-color, datepicker-locale, datepicker-value, expansion-steps, focus-monitor-directives, focus-monitor-focus-via, focus-monitor-overview, form-field-label, input-form, paginator-configurable, sidenav-backdrop, snack-bar-overview, snack-bar-position, text-field-autofill-directive, text-field-autofill-monitor, text-field-autosize-textarea
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the amount of spacing between crowded UI elements in the following examples: button-toggle-appearance, datepicker-api, datepicker-color, datepicker-locale, datepicker-value, expansion-steps, focus-monitor-directives, focus-monitor-focus-via, focus-monitor-overview, form-field-label, input-form, paginator-configurable, sidenav-backdrop, snack-bar-overview, snack-bar-position, text-field-autofill-directive, text-field-autofill-monitor, text-field-autosize-textarea