Skip to content

chore(schematics): create upgrade schematic for v8 #15442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

chore(schematics): create upgrade schematic for v8 #15442

merged 1 commit into from
Mar 22, 2019

Conversation

josephperrott
Copy link
Member

  • Create the initial v8 upgrade schematic
  • Create TSLint rule schematic to update imports to subpackage imports for @angular/material

@josephperrott josephperrott added the target: major This PR is targeted for the next major release label Mar 11, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2019
@josephperrott josephperrott added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Mar 11, 2019
devversion
devversion reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🎉 Just a few nits.

src/lib/schematics/ng-update/test-cases/v8/material-subpackage_expected_output.ts
MatTabsModule,
MatToolbarModule,
MatTooltipModule
} from '@angular/material';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that test-case incorrect? Shouldn't it import from the secondary entry-points?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might have not added the rule to he upgrade rules right?

https://github.com/angular/material2/blob/f82259bac2169a049977b4b64cab3a6e52b79bb1/src/lib/schematics/ng-update/index.ts#L16-L27

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your right, it looks like it is still not executing. I am not sure what I am missing to have it included as it should be matched by the glob in the BAZEL file.

@josephperrott
chore(schematics): create upgrade schematic for v8
272f96d 
- Create the initial v8 upgrade schematic
- Create TSLint rule schematic to update imports to subpackage imports for @angular/material
@josephperrott josephperrott force-pushed the material-package-imports branch from de06c55 to 272f96d Compare March 14, 2019 16:48
devversion
devversion approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some very small whitespace nits.

As mentioned on Slack. I'm not sure if we can get the test case working without bring in Material into the testing environment, or creating a mock. Maybe better in a follow-up?

...ib/schematics/ng-update/upgrade-rules/package-imports-v8/updateAngularMaterialImportsRule.ts
}

// The filename for the source file of the node that contains the
// first declaration of the symbol. All symbol declarations must be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace

...ib/schematics/ng-update/upgrade-rules/package-imports-v8/updateAngularMaterialImportsRule.ts
return ctx.addFailureAtNode(
element, element.getFullText(sf) + Rule.SYMBOL_FILE_NOT_FOUND_FAILURE_STR);
}
// The module name where the symbol is defined e.g. card, dialog. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace

...ib/schematics/ng-update/upgrade-rules/package-imports-v8/updateAngularMaterialImportsRule.ts

// If the symbol has no declarations, add failure saying the symbol can't
// be found.
if (!symbol.declarations || !symbol.declarations.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary now.

...ib/schematics/ng-update/upgrade-rules/package-imports-v8/updateAngularMaterialImportsRule.ts

/**
* Builds the recommended fix from a map of the imported symbols found in the
* import declaration. Imports declarations are sorted by module, then by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 14, 2019
@ngbot
Copy link

ngbot bot commented Mar 19, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added this to the 8.0.0 milestone Mar 21, 2019
jelbourn
jelbourn approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 177a433 into angular:master Mar 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the material-package-imports branch March 20, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @jelbourn @devversion @googlebot @andrewseguin