Skip to content

fix(tooltip): render style values in ngOnInit instead of the constructor #15468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2019
Merged

fix(tooltip): render style values in ngOnInit instead of the constructor #15468

merged 1 commit into from
Mar 14, 2019

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 13, 2019

Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the ToolTip component.

@matsko matsko requested a review from andrewseguin as a code owner March 13, 2019 21:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Mar 13, 2019
crisbeto
crisbeto reviewed Mar 13, 2019
View reviewed changes
src/lib/tooltip/tooltip.spec.ts Outdated
@@ -812,7 +812,7 @@ describe('MatTooltip', () => {

describe('special cases', () => {

it('should clear the `user-select` when a tooltip is set on a text field', () => {
fit('should clear the `user-select` when a tooltip is set on a text field', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover fit?

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2019
@ngbot
Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Mar 13, 2019
@matsko
fix(tooltip): render style values in ngOnInit instead of the constructor
db6e3e8 
Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the `ToolTip` component.
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 14, 2019
@mmalerba mmalerba merged commit 74583b9 into angular:ivy-2019 Mar 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matsko @crisbeto @googlebot @mmalerba