Skip to content

fix(stepper): content not being rendered out initially with ivy #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

crisbeto
Copy link
Member

Equivalent of #15485 for the Ivy branch.

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Mar 14, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 14, 2019 18:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 14, 2019
@ngbot
Copy link

ngbot bot commented Mar 14, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *
    pending status "ci/circleci: bazel_build_test" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 81d9995 into angular:ivy-2019 Mar 14, 2019
crisbeto added a commit to crisbeto/angular that referenced this pull request Mar 14, 2019
Removes the stepper-related tests from the blocklist which were fixed by angular/components#15486.
matsko pushed a commit to angular/angular that referenced this pull request Mar 14, 2019
Removes the stepper-related tests from the blocklist which were fixed by angular/components#15486.

PR Close #29314
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
Removes the stepper-related tests from the blocklist which were fixed by angular/components#15486.

PR Close angular#29314
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants