fix(material/radio): able to focus disabled radio button via click #15499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 15, 2019
Along the same lines as angular#15499. Fixes the slide toggle being focusable via click when it's disabled.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 16, 2019
Along the same lines as angular#15499. Fixes the slide toggle being focusable via click when it's disabled.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 18, 2019
Along the same lines as angular#15499. Fixes users being able to focus a disabled button toggle by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
andrewseguin
pushed a commit
that referenced
this pull request
Mar 20, 2019
) Along the same lines as #15499. Fixes the slide toggle being focusable via click when it's disabled.
andrewseguin
pushed a commit
that referenced
this pull request
Mar 25, 2019
) Along the same lines as #15499. Fixes the slide toggle being focusable via click when it's disabled.
|
As previously discussed, we should explore another way of dealing with the focus redirect for this component. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 2, 2019
Along the same lines as angular#15499. Fixes users being able to focus a disabled button toggle by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
crisbeto
force-pushed
the
15493/disabled-radio-focus
branch
from
2249e16 to
549e497
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
15493/disabled-radio-focus
branch
from
549e497 to
0792d7d
Compare
crisbeto
force-pushed
the
15493/disabled-radio-focus
branch
from
0792d7d to
bb64336
Compare
|
@jelbourn do you remember the context behind figuring out a different approach to dealing with the focus redirect that you mentioned above? I think that this is still a problem which also ended up being transferred to the MDC-based radio button. I think that we should fix it, regardless of whether we decide to change the focus management afterwards. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 22, 2020
…tton via click We have an existing fix for the regular radio button at angular#15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 22, 2020
…tton via click We have an existing fix for the regular radio button at angular#15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
jelbourn
pushed a commit
that referenced
this pull request
Feb 26, 2020
…tton via click (#18584) We have an existing fix for the regular radio button at #15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
jelbourn
pushed a commit
that referenced
this pull request
Mar 3, 2020
…tton via click (#18584) We have an existing fix for the regular radio button at #15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled. (cherry picked from commit 7ba45d9)
|
Adding |
This was referenced Mar 27, 2020
crisbeto
force-pushed
the
15493/disabled-radio-focus
branch
from
bb64336 to
3b9a7c8
Compare
crisbeto
changed the title
Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled. Fixes angular#15493.
crisbeto
force-pushed
the
15493/disabled-radio-focus
branch
from
3b9a7c8 to
ee208d4
Compare
|
Closing since this isn't necessary anymore, because we remove the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
Fixes #15493.