Skip to content

fix(snackbar): don't use template string in metadata #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2016
Merged

fix(snackbar): don't use template string in metadata #1550

merged 2 commits into from
Oct 20, 2016

Conversation

jelbourn
Copy link
Member

R: @andrewseguin or @tinayuangao

Also remove unused component in demo.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2016
andrewseguin
andrewseguin approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tinayuangao
tinayuangao approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit aa250d4 into angular:master Oct 20, 2016
@jelbourn jelbourn deleted the snackbar-aot-fix branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @tinayuangao @andrewseguin @googlebot