fix(bottom-sheet): unable to reopen same bottom sheet after closing via back button #15520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…ia back button Fixes not being able to reopen the same bottom sheet, if the user closed it by pressing back. The issue comes from the fact that we only consider the bottom sheet as closed when its animation completes, however that might not happen if the component is destroyed. The following changes work around the issue by completing the closing sequence on detach, rather than depending on the animation. Fixes angular#15510.
crisbeto
force-pushed
the
15510/bottom-sheet-back-reopen
branch
from
9b6ebd5 to
17d31da
Compare
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Apr 4, 2019
…ia back button (#15520) Fixes not being able to reopen the same bottom sheet, if the user closed it by pressing back. The issue comes from the fact that we only consider the bottom sheet as closed when its animation completes, however that might not happen if the component is destroyed. The following changes work around the issue by completing the closing sequence on detach, rather than depending on the animation. Fixes #15510.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is difficult to capture in a unit test, because it depends on things from the router and animations hence why a test has been omitted here.
Fixes not being able to reopen the same bottom sheet, if the user closed it by pressing back. The issue comes from the fact that we only consider the bottom sheet as closed when its animation completes, however that might not happen if the component is destroyed. The following changes work around the issue by completing the closing sequence on detach, rather than depending on the animation.
Fixes #15510.