Skip to content

refactor(badge): rework to account for ivy changes #15555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

refactor(badge): rework to account for ivy changes #15555

merged 1 commit into from
Mar 22, 2019

Conversation

crisbeto
Copy link
Member

Reworks matBadge to account for Ivy setting static inputs before the view has been rendered out. This caused one of the tests to fail, because it relied on the view being in place when the content setter is called.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 20, 2019 21:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2019
@crisbeto crisbeto mentioned this pull request Mar 20, 2019
Merged
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 20, 2019
@ngbot
Copy link

ngbot bot commented Mar 20, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: build_devapp_aot" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

jelbourn
jelbourn reviewed Mar 21, 2019
View reviewed changes
src/lib/badge/badge.ts
const contentChange = changes.content;

if (contentChange) {
const value = contentChange.currentValue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here like

// It's important that this happens in onChanges rather than in a setter because...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jelbourn
jelbourn approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewseguin
andrewseguin reviewed Mar 22, 2019
View reviewed changes
@crisbeto
refactor(badge): rework to account for ivy changes
37dc704 
Reworks `matBadge` to account for Ivy setting static inputs before the view has been rendered out. This caused one of the tests to fail, because it relied on the view being in place when the `content` setter is called.
@andrewseguin andrewseguin merged commit f889547 into angular:master Mar 22, 2019
crisbeto added a commit to crisbeto/angular that referenced this pull request Mar 22, 2019
@crisbeto
test(ivy): remove passing test from blocklist
7303c04 
Removes the test that was fixed by angular/components#15555 from the blocklist.
@crisbeto crisbeto mentioned this pull request Mar 22, 2019
Closed
mhevery pushed a commit to angular/angular that referenced this pull request Mar 22, 2019
@crisbeto @mhevery
test(ivy): remove passing test from blocklist (#29484)
cfe6581 
Removes the test that was fixed by angular/components#15555 from the blocklist.

PR Close #29484
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 25, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@crisbeto @wKoza
test(ivy): remove passing test from blocklist (angular#29484)
efd32fd 
Removes the test that was fixed by angular/components#15555 from the blocklist.

PR Close angular#29484
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @andrewseguin @googlebot