-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: serve ivy dev-app with lazy loading #15557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,104
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 44f185b.
* Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Mar 20, 2019
In order to be in sync as much as possible with angular#15557
mmalerba
approved these changes
Mar 21, 2019
andrewseguin
pushed a commit
that referenced
this pull request
Mar 22, 2019
In order to be in sync as much as possible with #15557
andrewseguin
pushed a commit
that referenced
this pull request
Mar 25, 2019
In order to be in sync as much as possible with #15557
JoostK
pushed a commit
to JoostK/components
that referenced
this pull request
May 7, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
JoostK
pushed a commit
to JoostK/components
that referenced
this pull request
Jul 9, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.sh
script works if Gulp is not installed globally.