Skip to content

build: serve ivy dev-app with lazy loading #15557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 20, 2019

  • Updates the Ivy script/build pipeline to support lazy-loading with the dev-app.
  • Removes duplicate lazy routes (otherwise causes error within rollup; to be in sync: build: remove duplicate route definitions #15558)
  • Ensures Ivy Angular install script ensures clean Ivy packages are installed
  • Ensures Ivy build.sh script works if Gulp is not installed globally.

* Updates the Ivy script/build pipeline to support lazy-loading with the dev-app.
* Removes duplicate lazy routes (otherwise causes error within rollup)
* Ensures Ivy Angular install script ensures clean Ivy packages are installed
* Ensures Ivy `build.sh` script works if Gulp is not installed globally.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2019
@devversion devversion marked this pull request as ready for review March 20, 2019 23:01
devversion added a commit to devversion/material2 that referenced this pull request Mar 20, 2019
In order to be in sync as much as possible with angular#15557
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 21, 2019
@ngbot
Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Member

crisbeto commented Mar 21, 2019

One thing that can up in the last Ivy meeting that might be nice: currently when you build, you end up with some untracked files under src. Can we add those to the gitignore? For reference:

Screenshot at Mar 21 08-40-48

@devversion
Copy link
Member Author

@crisbeto Looking into that in a separate PR. @kara mentioned it as well but I didn't notice such files last time. will double-check.

@jelbourn jelbourn merged commit a18a195 into angular:ivy-2019 Mar 21, 2019
@devversion devversion deleted the ivy-2019-lazy-loading branch March 22, 2019 08:02
andrewseguin pushed a commit that referenced this pull request Mar 22, 2019
In order to be in sync as much as possible with #15557
andrewseguin pushed a commit that referenced this pull request Mar 25, 2019
In order to be in sync as much as possible with #15557
JoostK pushed a commit to JoostK/components that referenced this pull request May 7, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)""

This reverts commit 44f185b.

* build: serve ivy dev-app with lazy loading

* Updates the Ivy script/build pipeline to support lazy-loading with the dev-app.
* Removes duplicate lazy routes (otherwise causes error within rollup)
* Ensures Ivy Angular install script ensures clean Ivy packages are installed
* Ensures Ivy `build.sh` script works if Gulp is not installed globally.
JoostK pushed a commit to JoostK/components that referenced this pull request Jul 9, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)""

This reverts commit 44f185b.

* build: serve ivy dev-app with lazy loading

* Updates the Ivy script/build pipeline to support lazy-loading with the dev-app.
* Removes duplicate lazy routes (otherwise causes error within rollup)
* Ensures Ivy Angular install script ensures clean Ivy packages are installed
* Ensures Ivy `build.sh` script works if Gulp is not installed globally.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants