Skip to content

fix(sidenav): some internal subjects not being completed #15567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

fix(sidenav): some internal subjects not being completed #15567

merged 1 commit into from
Mar 28, 2019

Conversation

crisbeto
Copy link
Member

Fixes a couple of internal subjects not being completed in MatDrawer and MatDrawerContainer.

@crisbeto
fix(sidenav): some internal subjects not being completed
ff92ecb 
Fixes a couple of internal subjects not being completed in MatDrawer and MatDrawerContainer.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 21, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 21, 2019 20:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 21, 2019
@molayodecker
Copy link

Can addition authorized users review this PR and merge it. @crisbeto @mmalerba @mprobst

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@jelbourn jelbourn merged commit ab5e3c8 into angular:master Mar 28, 2019
jelbourn pushed a commit that referenced this pull request Apr 4, 2019
@crisbeto @jelbourn
fix(sidenav): some internal subjects not being completed (#15567)
073e542 
Fixes a couple of internal subjects not being completed in MatDrawer and MatDrawerContainer.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @molayodecker @mmalerba @jelbourn @googlebot