build: update to typescript 3.2

[crisbeto]

Updates to TypeScript 3.2 and fixes some compilation errors.

[jelbourn]

LGTM

[devversion]

LGTM, other than the small question.

[devversion]

Why do we need to export the typescript thing here? Shouldn't everything just use the agnostic TypeScript version which is also typed?

[crisbeto]

My understanding is that the ts and the typescript refer to two different namespaces. ts didn't have SourceFile which we needed.

[devversion]

The ts object should be typed with typeof typescript but I could see that this one omits the actual types as it's not declared as namespace. Though it feels ambiguous to export ts and typescript.

Why can't we just rely on the implicit type from ts.createSourceFile? I don't bother too much, but there is definitely some ambiguity now. If you want to explicitly type it, how about just importing typescript there and type it from there? We just need to use the agnostic TS version at runtime

[crisbeto]

We can't let it infer the type from createSourceFile, because Bazel was throwing an error about a dependency being brought in implicitly.

[devversion]

hmm. There should be no change of transitive dependencies with the current changes. I'm okay getting it in like that. I can just explore cleaning up the ambiguous export in a follow-up then.

[jelbourn]

@crisbeto could you rebase?

[crisbeto]

Rebased.

[jelbourn]

This was merge-safe all along (we don't sync schematics)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}