Skip to content

build: re-enable all temporary disabled e2e tests #15623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2019

Conversation

devversion
Copy link
Member

No description provided.

Updates all Angular packages expect "@angular/compiler-cli" to
the latest beta version. This allows us to pick up recent Bazel fixes
which allow us to fully re-enable all e2e tests. Additionally we can
now update to the latest `rules_nodejs` version that switched from
`rollup` to `terser`.

Additionally since we updated `@angular/[email protected]`, we
can take advantage of angular/angular@105cfaf
and move forward with using the Bazel `ng_package` output for the NPM
release output.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@ngbot
Copy link

ngbot bot commented Mar 27, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: bazel_build_test" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

The NodeJS rule now transitively bring in the `source-map-support` dependency and
therefore we don't need to add it to various Bazel targets.

Also specifying the `jasmine` attribute is currently not working as it breaks
the runfile dependency of `@npm//@bazel/jasmine`. `@bazel/jasmine`
transitively brings its own version of `jasmine`.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 27, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 31f753a into angular:master Mar 27, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants