-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: re-enable all temporary disabled e2e tests #15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates all Angular packages expect "@angular/compiler-cli" to the latest beta version. This allows us to pick up recent Bazel fixes which allow us to fully re-enable all e2e tests. Additionally we can now update to the latest `rules_nodejs` version that switched from `rollup` to `terser`. Additionally since we updated `@angular/[email protected]`, we can take advantage of angular/angular@105cfaf and move forward with using the Bazel `ng_package` output for the NPM release output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The NodeJS rule now transitively bring in the `source-map-support` dependency and therefore we don't need to add it to various Bazel targets. Also specifying the `jasmine` attribute is currently not working as it breaks the runfile dependency of `@npm//@bazel/jasmine`. `@bazel/jasmine` transitively brings its own version of `jasmine`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.