refactor: constructor breaking changes for 8.0 #15647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
8.0-constructor-changes-part-1
branch
3 times, most recently
from
6531d44 to
9574644
Compare
|
@crisbeto can you separate the stepper changes into a another PR? I think the rest will go in easily |
crisbeto
force-pushed
the
8.0-constructor-changes-part-1
branch
from
9574644 to
cd4c056
Compare
|
I've removed the stepper-related changes @mmalerba. |
Goes through the constructor-related breaking changes for 8.0 in all of the CDK symbols plus `material/form-field` and `material/tabs`. BREAKING CHANGES: * `CdkDrag`: `viewportRuler` and `dragDropRegistry` parameters have been removed from the constructor. Furthermore the `dragDrop` and `_changeDetectorRef` parameters in are now required. * `CdkDropList`: `dragDropRegistry` and `_documents` parameters have been removed, and `dragDrop` parameter is now required. * `ConnectedPositionStrategy`: `platform` parameter is now required and a new `overlayContainer` parameter has been added. * `FlexibleConnectedPositionStrategy`: `_platform` and `_overlayContainer` parameters are now required. * `OverlayPositionBuilder`: `_platform` and `_overlayContainer` parameters are now required. * `CdkTable`: `_document` and `_platform` parameters are now required. * `MatFormField`: `_platform`, `_ngZone` and `_animationMode` parameters are now required. * `MatTabLink`: `_focusMonitor` parameter is now required.
mmalerba
force-pushed
the
8.0-constructor-changes-part-1
branch
from
cd4c056 to
b752c0c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes through the constructor-related breaking changes for 8.0 in all of the CDK symbols plus
material/form-fieldandmaterial/tabs.BREAKING CHANGES:
CdkDrag:viewportRuleranddragDropRegistryparameters have been removed from the constructor. Furthermore thedragDropand_changeDetectorRefparameters in are now required.CdkDropList:dragDropRegistryand_documentsparameters have been removed, anddragDropparameter is now required.ConnectedPositionStrategy:platformparameter is now required and a newoverlayContainerparameter has been added.FlexibleConnectedPositionStrategy:_platformand_overlayContainerparameters are now required.OverlayPositionBuilder:_platformand_overlayContainerparameters are now required.CdkTable:_documentand_platformparameters are now required.MatFormField:_platform,_ngZoneand_animationModeparameters are now required.MatTabLink:_focusMonitorparameter is now required.