Skip to content

refactor(expansion): constructor breaking changes for 8.0 #15722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

refactor(expansion): constructor breaking changes for 8.0 #15722

merged 1 commit into from
Apr 11, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2019

  • Applies the breaking changes for material/expansion for 8.0.
  • Fixes a symbol that made it into the upgrade schematic by accident.

BREAKING CHANGES:

  • The _document and _animationMode parameters are now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Apr 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2019
@crisbeto crisbeto force-pushed the expansion-panel-constructor-changes branch from d254ce4 to 5168760 Compare April 4, 2019 20:44
jelbourn
jelbourn approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 8, 2019
@crisbeto
refactor(expansion): constructor breaking changes for 8.0
08d99c7 
* Applies the breaking changes for `material/expansion` for 8.0.
* Fixes a symbol that made it into the upgrade schematic by accident.

BREAKING CHANGES:
* The `_document` and `_animationMode` parameters are now required.
@crisbeto crisbeto force-pushed the expansion-panel-constructor-changes branch from 5168760 to 08d99c7 Compare April 11, 2019 18:05
@andrewseguin andrewseguin merged commit d071775 into angular:master Apr 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin