fix(material/chips): allow for role to be overwritten on chip list and chip #15794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Apr 11, 2019
src/lib/chips/chip-list.ts
Outdated
| @@ -165,7 +165,18 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo | |||
| } | |||
|
|
|||
| /** The ARIA role applied to the chip list. */ | |||
| get role(): string | null { return this.empty ? null : 'listbox'; } | |||
| @Input() | |||
| get role(): string | null { | |||
There was a problem hiding this comment.
Note: I'm not a fan of this property signature (having | null), but I kept it for backwards compatibility. Since the property was readonly until now we could get away with changing it to just be a string.
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
15787/chips-role
branch
from
75927e5 to
c7c3925
Compare
andrewseguin
added
the
P4
crisbeto
force-pushed
the
15787/chips-role
branch
from
c7c3925 to
982bc37
Compare
crisbeto
force-pushed
the
15787/chips-role
branch
from
982bc37 to
86ffda4
Compare
crisbeto
force-pushed
the
15787/chips-role
branch
from
86ffda4 to
744d033
Compare
crisbeto
force-pushed
the
15787/chips-role
branch
from
744d033 to
34058d2
Compare
crisbeto
force-pushed
the
15787/chips-role
branch
from
34058d2 to
4e052bd
Compare
crisbeto
force-pushed
the
15787/chips-role
branch
from
4e052bd to
1504b3d
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
crisbeto
changed the title
…d chip Allows for the ARIA `role` of the `mat-chip-list` and `mat-chip` to be overwritten. Fixes angular#15787.
crisbeto
force-pushed
the
15787/chips-role
branch
from
1504b3d to
8353dc5
Compare
crisbeto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the ARIA
roleof themat-chip-listandmat-chipto be overwritten.Fixes #15787.