Skip to content

refactor(slide-toggle): constructor breaking changes for 8.0 #15806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

refactor(slide-toggle): constructor breaking changes for 8.0 #15806

merged 1 commit into from
Apr 23, 2019

Conversation

crisbeto
Copy link
Member

Goes through the breaking constructor changes in material/slide-toggle for 8.0

BREAKING CHANGES:

  • _platform parameter has been removed from the MatSlideToggle constructor.

@crisbeto
refactor(slide-toggle): constructor breaking changes for 8.0
ebcc0da 
Goes through the breaking constructor changes in `material/slide-toggle` for 8.0

BREAKING CHANGES:
* `_platform` parameter has been removed from the `MatSlideToggle` constructor.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Apr 12, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2019
devversion
devversion approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 13, 2019
@mmalerba mmalerba merged commit a23d787 into angular:master Apr 23, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
refactor(slide-toggle): constructor breaking changes for 8.0 (angular…
bb021d1 
…#15806)

Goes through the breaking constructor changes in `material/slide-toggle` for 8.0

BREAKING CHANGES:
* `_platform` parameter has been removed from the `MatSlideToggle` constructor.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @googlebot @mmalerba