Skip to content

fix(stepper): Fix visual flake in focusing stepper header #15870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

mitchellwills
Copy link
Contributor

When the step is changed through a button click sometimes the focus of the new
step header is attributed by focus monitor to 'mouse' instead of 'program'. This
results in a visual difference in the step header (focus background is missing).
Instead, when focusing the step header focus it via 'program' explicitly through
the focus monitor.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 21, 2019
@jelbourn jelbourn added the G This is is related to a Google internal issue label Apr 22, 2019
@jelbourn jelbourn requested review from crisbeto and mmalerba April 22, 2019 17:26
@jelbourn
Copy link
Member

@mmalerba could you take a look at this PR?

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 23, 2019
@ngbot
Copy link

ngbot bot commented Apr 23, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Apr 23, 2019
@mitchellwills
Copy link
Contributor Author

I updated the public API file to take into account the "api change" (not sure if this counts as a change since it's already inherited as a public method from the parent).
Let me know if this wasn't the right fix for the test

When the step is changed through a button click sometimes the focus of the new
step header is attributed by focus monitor to 'mouse' instead of 'program'. This
results in a visual difference in the step header (focus background is missing).
Instead, when focusing the step header focus it via 'program' explicitly through
the focus monitor.
@mmalerba mmalerba merged commit 8b5c0f1 into angular:master Apr 25, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
)

When the step is changed through a button click sometimes the focus of the new
step header is attributed by focus monitor to 'mouse' instead of 'program'. This
results in a visual difference in the step header (focus background is missing).
Instead, when focusing the step header focus it via 'program' explicitly through
the focus monitor.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants