Skip to content

fix(autocomplete): make template ViewChild query static: true #15877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2019
Merged

fix(autocomplete): make template ViewChild query static: true #15877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/autocomplete/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ export class MatAutocomplete extends _MatAutocompleteMixinBase implements AfterC
get isOpen(): boolean { return this._isOpen && this.showPanel; }
_isOpen: boolean = false;

// The @ViewChild query for TemplateRef here needs to be static because some code paths
// lead to the overlay being created before change detection has finished for this component.
// Notably, another component may trigger `focus` on the autocomplete-trigger.

/** @docs-private */
@ViewChild(TemplateRef, {static: false}) template: TemplateRef<any>;
@ViewChild(TemplateRef, {static: true}) template: TemplateRef<any>;

/** Element for the panel containing the autocomplete options. */
@ViewChild('panel', {static: false}) panel: ElementRef;
Expand Down