-
Notifications
You must be signed in to change notification settings - Fork 6.8k
prototype(button): create prototype button based on MDC Web #15887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
21f0055
to
39de594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more batch of nits
a96acb1
to
c24e7d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside for the CI issues
related to #16196 |
…15887) * prototype(button): create prototype button based on MDC Web * fix BUILD * add focus method to button base * build: rename lib to material * add comments to ripple styles; remove position relative; merge mixins * put button HTML into file * fix lint * move sass rules out of theme; cleanup typography styles * build fix * build fix
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Prototype of using MDC Web for the base of our button component. Remaining issues and todo tasks are left in the README