Skip to content

prototype(button): create prototype button based on MDC Web #15887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2019

Conversation

andrewseguin
Copy link
Contributor

Prototype of using MDC Web for the base of our button component. Remaining issues and todo tasks are left in the README

@andrewseguin andrewseguin requested a review from mmalerba April 23, 2019 18:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 23, 2019
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more batch of nits

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside for the CI issues

@mmalerba mmalerba added pr: lgtm target: major This PR is targeted for the next major release labels Apr 26, 2019
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Apr 26, 2019
@mmalerba mmalerba merged commit c0d493f into angular:master Apr 26, 2019
@mmalerba
Copy link
Contributor

related to #16196

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
…15887)

* prototype(button): create prototype button based on MDC Web

* fix BUILD

* add focus method to button base

* build: rename lib to material

* add comments to ripple styles; remove position relative; merge mixins

* put button HTML into file

* fix lint

* move sass rules out of theme; cleanup typography styles

* build fix

* build fix
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants