Skip to content

chore: fix inherited host binding issue with sidenav #15895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2019
Merged

chore: fix inherited host binding issue with sidenav #15895

merged 2 commits into from
Apr 25, 2019

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Apr 24, 2019

Due to the inheritance changes present in the Ivy refactor,
animation host bindings are being inherited into a the SideNav
sub component unexpectedly. This patch ensures that SideNav
uses the same animation binding as does its super class.

@matsko
chore: fix inherited host binding issue with sidenav
942a98c 
Due to the inheritance changes present in the Ivy refactor,
animation host bindings are being inherited into a the SideNav
sub component unexpectedly. This patch ensures that SideNav
uses the same animation binding as does its super class.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2019
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 24, 2019
@mmalerba mmalerba marked this pull request as ready for review April 24, 2019 21:26
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Apr 24, 2019
@mmalerba mmalerba merged commit 07a16de into angular:master Apr 25, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@matsko @RudolfFrederiksen
chore: fix inherited host binding issue with sidenav (angular#15895)
10f2a45 
Due to the inheritance changes present in the Ivy refactor,
animation host bindings are being inherited into a the SideNav
sub component unexpectedly. This patch ensures that SideNav
uses the same animation binding as does its super class.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matsko @mmalerba @googlebot