fix(drag-n-drop): ignore consecutive touchmove events on drag item on multitouch #15923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multitouch Bumped into an inconsistent behaviour on multitouch. Currently the DragDropRegistry is designed atop of Set, and assumes there could be only one pointer active on item. Which is not true for multitouch devices. So there’re two ways to fix it: 1. Teach DragDropRegistry to respect multiple simultaneous pointers on one item. 2. Stick to Set as designed initially, respect only the first pointer on item, and properly ignore all consecutive pointers. The first way looks much more promising, but requires much more effort and requires attention of core team, I suppose. The second one is not that flexible, but is still more consistent than the current implementation. So this commit implements the second way.
googlebot
added
the
cla: yes
crisbeto
reviewed
May 13, 2019
crisbeto
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped into an inconsistent behaviour on multitouch. Currently the DragDropRegistry is designed atop of Set, and assumes there could be only one pointer active on item. Which is not true for multitouch devices.
So there’re two ways to fix it:
The first way looks much more promising, but requires much more effort and requires attention of core team, I suppose. The second one is not that flexible, but is still more consistent than the current implementation. So this commit implements the second way.