fix(overlay): stop using capture phase for overlay keyboard handling #16019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stevenyxu
force-pushed
the
capture
branch
2 times, most recently
from
b0bbc54 to
aa8fe3c
Compare
OverlayKeyboardDispatcher is a document-level keyboard listener that dispatches events to the topmost overlay that's listening for them. It does it on capture as of e30852a in order to avoid missing events whose propagation have been stopped. However, there are legitimate use cases for stopping propagation and not wanting the overlay to hear about it. For example, grid navigation based on the ARIA best practice allows for enter to trap focus inside a grid cell and escape to leave it and restore focus to the grid cell. https://www.w3.org/TR/wai-aria-practices-1.1/#gridNav_inside In these cases, we must be able to call stopPropagation and prevent the escape keypress event from reaching the overlay. Fixes angular#9928. BREAKING CHANGE: OverlayKeyboardDispatcher (used in dialog and overlay and available in the CDK) now listens on bubbling/propagation phase instead of capture phase. This means that overlay keydown handlers are now called after any applicable handlers inside of an overlay, and it respects any stopPropagation() calls from inside the overlay.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
added
the
P2
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
…16019) OverlayKeyboardDispatcher is a document-level keyboard listener that dispatches events to the topmost overlay that's listening for them. It does it on capture as of e30852a in order to avoid missing events whose propagation have been stopped. However, there are legitimate use cases for stopping propagation and not wanting the overlay to hear about it. For example, grid navigation based on the ARIA best practice allows for enter to trap focus inside a grid cell and escape to leave it and restore focus to the grid cell. https://www.w3.org/TR/wai-aria-practices-1.1/#gridNav_inside In these cases, we must be able to call stopPropagation and prevent the escape keypress event from reaching the overlay. Fixes #9928. BREAKING CHANGE: OverlayKeyboardDispatcher (used in dialog and overlay and available in the CDK) now listens on bubbling/propagation phase instead of capture phase. This means that overlay keydown handlers are now called after any applicable handlers inside of an overlay, and it respects any stopPropagation() calls from inside the overlay.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…ngular#16019) OverlayKeyboardDispatcher is a document-level keyboard listener that dispatches events to the topmost overlay that's listening for them. It does it on capture as of e30852a in order to avoid missing events whose propagation have been stopped. However, there are legitimate use cases for stopping propagation and not wanting the overlay to hear about it. For example, grid navigation based on the ARIA best practice allows for enter to trap focus inside a grid cell and escape to leave it and restore focus to the grid cell. https://www.w3.org/TR/wai-aria-practices-1.1/#gridNav_inside In these cases, we must be able to call stopPropagation and prevent the escape keypress event from reaching the overlay. Fixes angular#9928. BREAKING CHANGE: OverlayKeyboardDispatcher (used in dialog and overlay and available in the CDK) now listens on bubbling/propagation phase instead of capture phase. This means that overlay keydown handlers are now called after any applicable handlers inside of an overlay, and it respects any stopPropagation() calls from inside the overlay.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverlayKeyboardDispatcher is a document-level keyboard listener that
dispatches events to the topmost overlay that's listening for them.
It does it on capture as of e30852a in order to avoid missing events
whose propagation have been stopped. However, there are legitimate use
cases for stopping propagation and not wanting the overlay to hear about
it. For example, grid navigation based on the ARIA best practice allows
for enter to trap focus inside a grid cell and escape to leave it and
restore focus to the grid cell.
https://www.w3.org/TR/wai-aria-practices-1.1/#gridNav_inside
In these cases, we must be able to call stopPropagation and prevent the
escape keypress event from reaching the overlay.
Fixes #9928.