Skip to content

feat(portal): add new portal that projects DOM nodes #16101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

crisbeto
Copy link
Member

Adds a new type of portal called DomPortal which transfers the contents of a portal into the portal outlet and then restores them on destroy.

This was implemented initially for #14430.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2019
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label May 23, 2019
@crisbeto crisbeto marked this pull request as ready for review May 23, 2019 19:42
@crisbeto
Copy link
Member Author

I've reworked it based on the feedback @jelbourn.

@crisbeto
Copy link
Member Author

I've reworked it to move the entire portal element, rather than the content. Can you take another look @jelbourn @wnvko?

@wnvko
Copy link
Contributor

wnvko commented Jun 25, 2019

LGTM

@crisbeto
Copy link
Member Author

The latest set of feedback has been addressed @jelbourn.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebase

@crisbeto crisbeto force-pushed the element-portal branch 2 times, most recently from 463ed62 to d3ad339 Compare September 5, 2019 19:56
@crisbeto
Copy link
Member Author

crisbeto commented Sep 5, 2019

Rebased.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@crisbeto crisbeto requested a review from a team as a code owner September 5, 2019 20:05
@jelbourn
Copy link
Member

jelbourn commented Sep 6, 2019

@crisbeto both Google Analytics and Google Cloud extend BasePortalOutlet with custom outlets, so they break due to missing attachDomPortal. What do you think of adding a default implementation to the abstract class that throws a "not implemented" error? We can then remove that default impl in a major version

@crisbeto crisbeto removed the target: minor This PR is targeted for the next minor release label Sep 10, 2019
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Sep 10, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Nov 2, 2019
Adds a new type of portal called `DomPortal` which transfers the contents of a portal into the portal outlet and then restores them on destroy.

This was implemented initially for angular#14430.
@crisbeto
Copy link
Member Author

crisbeto commented Nov 6, 2019

Updated @mmalerba.

@mmalerba mmalerba merged commit d3d8859 into angular:master Nov 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants