Skip to content

build: option to ignore ci checks when staging release #16262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

build: option to ignore ci checks when staging release #16262

merged 1 commit into from
Jun 12, 2019

Conversation

devversion
Copy link
Member

Closes #16139

@devversion devversion requested a review from jelbourn as a code owner June 11, 2019 06:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2019
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 11, 2019
jelbourn
jelbourn approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 11, 2019
@ngbot
Copy link

ngbot bot commented Jun 11, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 8139358 into angular:master Jun 12, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@devversion @RudolfFrederiksen
build: option to ignore ci checks when staging release (angular#16262)
0a92701 
Closes angular#16139
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@devversion @andrewseguin
build: option to ignore ci checks when staging release (#16262)
ecbab30 
Closes #16139
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't block stage-release script on CI status
4 participants
@devversion @jelbourn @googlebot @mmalerba