fix(cdk/virtual-scroll): fix subpixel rounding errors on hdpi screens #16269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
changed the title
mmalerba
added
G
jelbourn
added
pr: lgtm
action: merge
crisbeto
approved these changes
Jun 22, 2019
| @@ -9,4 +9,6 @@ | |||
| Spacer used to force the scrolling container to the correct size for the *total* number of items | |||
| so that the scrollbar captures the size of the entire data set. | |||
| --> | |||
| <div class="cdk-virtual-scroll-spacer" [style.transform]="_totalContentSizeTransform"></div> | |||
| <div class="cdk-virtual-scroll-spacer" | |||
| [style.width]="orientation == 'horizontal' ? _totalContentSize + 'px' : ''" | |||
There was a problem hiding this comment.
nit: it might be micro-optimizing a bit, but would it make sense to have this logic inside the component when setting _totalContentSize? Otherwise Angular will run the ternary and the string concatenation on each change detection run.
There was a problem hiding this comment.
yeah, probably a good idea
Using `transform` appears to cause rounding errors that can accumulate and become significant after scrolling through a large number of items. Switching to `width` / `height` corrects this.
mmalerba
added a commit
that referenced
this pull request
Aug 14, 2019
* fix(cdk/virtual-scroll): fix subpixel rounding errors on hdpi screens Using `transform` appears to cause rounding errors that can accumulate and become significant after scrolling through a large number of items. Switching to `width` / `height` corrects this. * don't recalulate height/width during every change detection (cherry picked from commit b796b6e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
transformappears to cause rounding errors that can accumulate andbecome significant after scrolling through a large number of items.
Switching to
width/heightcorrects this.