Skip to content

fix(autocomplete): top option group not scrolled into view when going up #16343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix(autocomplete): top option group not scrolled into view when going up #16343

merged 1 commit into from
Sep 27, 2019

Conversation

crisbeto
Copy link
Member

Fixes the case where the user won't be able to see the top option group when reaching the first option via the arrow keys.

Replaces #8138 which was getting very stale.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 20, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2019
@crisbeto crisbeto mentioned this pull request Jun 20, 2019
Closed
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 20, 2019
jelbourn
jelbourn reviewed Jun 21, 2019
View reviewed changes
@crisbeto
fix(autocomplete): top option group not scrolled into view when going up
7baf780 
Fixes the case where the user won't be able to see the top option group when reaching the first option via the arrow keys.
@crisbeto crisbeto force-pushed the autocomplete-top-option-scroll-redo branch from 5902efb to 7baf780 Compare June 30, 2019 08:05
@crisbeto
Copy link
Member Author

I've addressed the feedback @jelbourn.

jelbourn
jelbourn approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Caretaker note: might cause some intended screenshot diffs

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@andrewseguin andrewseguin merged commit f797cac into angular:master Sep 27, 2019
andrewseguin pushed a commit that referenced this pull request Sep 30, 2019
@crisbeto @andrewseguin
fix(autocomplete): top option group not scrolled into view when going…
c0034d3 
… up (#16343)

Fixes the case where the user won't be able to see the top option group when reaching the first option via the arrow keys.

(cherry picked from commit f797cac)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin