Skip to content

chore: update example module #16372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

crisbeto
Copy link
Member

The example module is out of date so it generates git diffs when the local dev server is run.

The example module is out of date so it generates git diffs when the local dev server is run.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 24, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner June 24, 2019 19:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2019
@devversion
Copy link
Member

I wish we could remove this workaround soon... but I don't think angular/angular#30259 is really prioritized right now.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 3537e97 into angular:master Jun 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants