Skip to content

build: update ibazel to latest version w/ windows support #16448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Updates ibazel to the latest version. This version comes with long
awaited windows support that is now also usable in the components
repository (based on manual testing). In follow-ups we should work
towards switching away from gulp test to ibazel. Though we need to
ensure that common workflows like debugging are still possible.

Fixes #16405

Updates `ibazel` to the latest version. This version comes with long
awaited windows support that is now also usable in the components
repository (based on manual testing). In follow-ups we should work
towards switching away from `gulp test` to `ibazel`. Though we need to
ensure that common workflows like debugging are still possible.

Fixes angular#16405
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 4, 2019
@devversion devversion requested a review from jelbourn as a code owner July 4, 2019 07:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 4, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 8, 2019
@jelbourn jelbourn merged commit 50292b7 into angular:master Jul 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibazel cmd on Windows / update ibazel
3 participants