Skip to content

fix(expansion): show header focus state when expanded #16486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jul 9, 2019

The expansion-panel currently shows the header focus state when
collapsed. This is an a11y problem because there's no indicator of focus
state when expanded.

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Jul 9, 2019
@jelbourn jelbourn added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 23, 2019
@jelbourn jelbourn force-pushed the expansion-panel-expanded-focus branch from 94edb39 to 4c9227a Compare September 5, 2019 20:30
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@ngbot
Copy link

ngbot bot commented Sep 5, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_local_browsers" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

The expansion-panel currently shows the header focus state when
collapsed. This is an a11y problem because there's no indicator of focus
state when expanded.
@jelbourn jelbourn force-pushed the expansion-panel-expanded-focus branch from 4c9227a to 36a5da9 Compare September 6, 2019 20:32
@jelbourn jelbourn merged commit 7bf5e4e into angular:master Sep 9, 2019
@Splaktar
Copy link
Contributor

It looks like this fixes #14569?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants