refactor(tree): avoid improper query usage #16540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
tree-query-refactor
branch
from
4eb9921 to
7086935
Compare
crisbeto
added
P2
crisbeto
force-pushed
the
tree-query-refactor
branch
from
7086935 to
2092d2b
Compare
jelbourn
added
pr: lgtm
action: merge
5 tasks
|
Copying from slack: A bunch of targets are failing in Google on this because:
|
crisbeto
force-pushed
the
tree-query-refactor
branch
from
2092d2b to
fba7973
Compare
The way things are set up at the moment we have a `CdkNestedTreeNode` which uses a `ContentChildren` to find a `CdkTreeNodeOutlet` so that it knows where to render its content. On top of this we have a `MatNestedTreeNode` which extends `CdkNestedTreeNode` and defines it's own query at the same property, but looking for a `MatTreeNodeOutlet`. With this setup it means that both `CdkNestedTreeNode` and `MatNestedTreeNode` are trying to write to the same `nodeOutlet` property and it's by pure coincidence that it works. This is very fragile and it isn't guaranteed to work in future versions of the framework. These changes fix the issue by removing the query from the `MatNestedTreeNode` and providing the `MatTreeNodeOutlet` as a `CdkTreeNodeOutlet` so that the query on the `CdkNestedTreeNode` can pick it up.
crisbeto
force-pushed
the
tree-query-refactor
branch
from
fba7973 to
cf4f46c
Compare
|
Updated to remove the mixin class. |
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
The way things are set up at the moment we have a `CdkNestedTreeNode` which uses a `ContentChildren` to find a `CdkTreeNodeOutlet` so that it knows where to render its content. On top of this we have a `MatNestedTreeNode` which extends `CdkNestedTreeNode` and defines it's own query at the same property, but looking for a `MatTreeNodeOutlet`. With this setup it means that both `CdkNestedTreeNode` and `MatNestedTreeNode` are trying to write to the same `nodeOutlet` property and it's by pure coincidence that it works. This is very fragile and it isn't guaranteed to work in future versions of the framework. These changes fix the issue by removing the query from the `MatNestedTreeNode` and providing the `MatTreeNodeOutlet` as a `CdkTreeNodeOutlet` so that the query on the `CdkNestedTreeNode` can pick it up.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way things are set up at the moment we have a
CdkNestedTreeNodewhich uses aContentChildrento find aCdkTreeNodeOutletso that it knows where to render its content. On top of this we have aMatNestedTreeNodewhich extendsCdkNestedTreeNodeand defines it's own query at the same property, but looking for aMatTreeNodeOutlet. With this setup it means that bothCdkNestedTreeNodeandMatNestedTreeNodeare trying to write to the samenodeOutletproperty and it's by pure coincidence that it works. This is very fragile and it isn't guaranteed to work in future versions of the framework.These changes fix the issue by removing the query from the
MatNestedTreeNodeand providing theMatTreeNodeOutletas aCdkTreeNodeOutletso that the query on theCdkNestedTreeNodecan pick it up.cc @pkozlowski-opensource