Skip to content

Avoid unneeded slice+splice in _pageData #16555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Avoid unneeded slice+splice in _pageData #16555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/material/table/table-data-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,14 @@ export class MatTableDataSource<T> extends DataSource<T> {
}

/**
* Returns a paged splice of the provided data array according to the provided MatPaginator's page
* Returns a paged slice of the provided data array according to the provided MatPaginator's page
* index and length. If there is no paginator provided, returns the data array as provided.
*/
_pageData(data: T[]): T[] {
if (!this.paginator) { return data; }

const startIndex = this.paginator.pageIndex * this.paginator.pageSize;
return data.slice().splice(startIndex, this.paginator.pageSize);
return data.slice(startIndex, startIndex + this.paginator.pageSize);
}

/**
Expand Down