-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material-experimental): add test harness for slider #16688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a2b773f
to
51e4daa
Compare
@jelbourn @mmalerba I wasn't too sure how we can solve the
If we want to spend some more time exploring the options, I'd propose that we do this as a follow-up. That's why the logic for setting a value is in a separate commit. |
395344e
to
00c1d69
Compare
Ah that's interesting... I guess a real user would have similar difficulty using your slider if you didn't have it set so that all values can be reached via the keyboard or had more steps than pixels worth of track. I guess I would say go for the clicking approach like you've done and maybe document that if you have more steps than pixels the |
00c1d69
to
d0c8d50
Compare
@mmalerba Done. I'm wondering if we should consider providing a method for selecting a value through keyboard interaction too. The arrow keys allow granular control over the value since those allow changes by "one step value" but in order to provide meaningful methods.. we'd need to somehow determine the step value from within the harness (which requires some host bindings on the slider..). I think that's something we could explore in a follow-up PR. |
d0c8d50
to
1169198
Compare
I also agree that methods to increment/decrement by the step via keyboard would be good in a follow-up. |
1169198
to
7e8214d
Compare
src/material-experimental/mdc-slider/harness/slider-harness.spec.ts
Outdated
Show resolved
Hide resolved
src/material-experimental/mdc-slider/harness/slider-harness.spec.ts
Outdated
Show resolved
Hide resolved
7e8214d
to
f050b04
Compare
Resolves COMP-191.
f050b04
to
fdbffa0
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.