feat(material-experimental): add test harness for select #16710
Conversation
googlebot
added
the
cla: yes
Sets up the test harness for `mat-select`.
crisbeto
force-pushed
the
select-test-harness
branch
from
74f8994 to
5a3ddb7
Compare
crisbeto
added
P3
| } | ||
|
|
||
| /** Gets the select panel. */ | ||
| async getPanel(): Promise<TestElement> { |
There was a problem hiding this comment.
is there a reason to expose this element? what would a user do with it in a test?
There was a problem hiding this comment.
You can use it to look at the scroll position and the position of the dropdown itself. We have a bunch of our own tests that deal with the dropdown.
| } | ||
|
|
||
| /** Gets the options inside the select panel. */ | ||
| async getOptions(): Promise<TestElement[]> { |
There was a problem hiding this comment.
We could potentially expose an OptionHarness and OptionGroupHarness to make it easier to work with these. I'm not sure if its overkill for this case, but I kind of like the idea of avoiding giving the user TestElement references when possible.
I would at least add an optional parameter to these methods so I can do something like getOptionGroups('Food') or getOptions('Pizza'). If you make a OptionHarness this could be an OptionHarnessFilters instead of a string.
Curious if @jelbourn has an opinion here
There was a problem hiding this comment.
We can do it on the second pass once both the autocomplete and select harnesses get in since both of them use mat-option.
There was a problem hiding this comment.
Agreed, I think we should have harnesses for the options. It can go in a follow-up PR.
jelbourn
added
pr: lgtm
action: merge
|
LGTM, please just add a TODO about the option harness |
Sets up the test harness for `mat-select`. (cherry picked from commit 89c784c)
Follow-up from angular#16620 and angular#16710. Adds a dedicated harness for `mat-option` and `mat-optgroup`. Note that some of the code is duplicated. This is because we don't have a shared place where to put the harness so that `mat-autocomplete` and `mat-select` don't have to depend on each other. I've intentionally kept the harnesses to only the methods we need, but once we have `experimental/core`, I'll combine them and implement all of the states that are supported by `mat-option`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sets up the test harness for
mat-select.