feat(material-experimental/mdc-chips): add harness skeleton #16737
Conversation
googlebot
added
the
cla: yes
andrewseguin
added
P2
| } | ||
|
|
||
| /** Gets promise of the chip input harness. */ | ||
| async getInput(): Promise<MatChipInputHarness|null> { |
There was a problem hiding this comment.
What do you think of getTextInput? I'm thinking that just "input" by itself might be too ambiguous
| static hostSelector = 'mat-basic-chip, mat-chip'; | ||
|
|
||
| /** Gets a promise for the text content the option. */ | ||
| async getTextContent(): Promise<string> { |
There was a problem hiding this comment.
Just getText? That's what I used for button and I think we should probably be consistent
|
|
||
| /** Gets a promise for the disabled state. */ | ||
| async isDisabled(): Promise<boolean> { | ||
| const ariaSelected = (await this.host()).getAttribute('aria-disabled'); |
| } | ||
|
|
||
| /** Gets a promise for the disabled state. */ | ||
| async isDisabled(): Promise<boolean> { |
There was a problem hiding this comment.
I'm not sure about this one. A chip by itself doesn't have any interactive role, and thus being disabled doesn't make sense.
There was a problem hiding this comment.
Maybe we should move this to the MatChipOptionHarness? Should we not support disabled on the base MatChip?
There was a problem hiding this comment.
I moved it to the option, we can evaluate whether the MdcMatChip should have disabled as an input
| * @dynamic | ||
| */ | ||
| export class MatChipInputHarness extends ComponentHarness { | ||
| static hostSelector = 'input.mat-mdc-chip-input'; |
There was a problem hiding this comment.
No, can't remember why I included that but it doesn't seem necessary
| /** Gets a promise for the disabled state. */ | ||
| async isDisabled(): Promise<boolean> { | ||
| const ariaSelected = (await this.host()).getAttribute('disabled'); | ||
| return await ariaSelected === 'true'; |
There was a problem hiding this comment.
Just one line?
return await ((await this.host()).getAttribute('disabled')) === 'true';There was a problem hiding this comment.
It's not as readable to me but perhaps my brain is still adjusting to awaits
|
|
||
| /** Gets promise of the selected options. */ | ||
| async getSelected(): Promise<MatChipOptionHarness[]> { | ||
| const options = await this._options(); |
There was a problem hiding this comment.
Simplify?
return (await this._options()).filter(o => await o.isSelected());(async functions automatically wrap non-promise return values into Promises)
andrewseguin
force-pushed
the
harness-chips
branch
from
8d666d4 to
786ea2f
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Covers the skeleton work for harnesses for the grid + rows + input, listbox + options, and set + chips.