feat(material-experimental/mdc-button): fix ripples #16773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Aug 13, 2019
mmalerba
reviewed
Aug 14, 2019
andrewseguin
force-pushed
the
mdc-button-ripple
branch
from
e935fb8 to
25d3db8
Compare
mmalerba
approved these changes
Aug 14, 2019
andrewseguin
added a commit
that referenced
this pull request
Aug 26, 2019
* feat(material-experimental/mdc-button): fix ripples * fix lint * revised based on reviews * add material to BUILD * get ripple numbers from constants * add ripple to BUILD for tests * leading underscore for ripple centered * actually fix test BUILD (cherry picked from commit de06e59)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out ripples were leaving their bounds.