feat(google-maps): Add methods and event handling to Google Map #16804
Conversation
googlebot
added
the
cla: yes
This comment has been minimized.
This comment has been minimized.
| ]); | ||
| const mouseEventHandlers = new Map<string, EventEmitter<google.maps.MouseEvent>>([ | ||
| ['dblclick', this.mapDblclick], | ||
| ['mousemove', this.mapMousemove], |
There was a problem hiding this comment.
Is the mousemove handler running inside the Angular zone? This might be one where we want to special case to run outside if so, otherwise we could end up running change detection hundreds of times if someone mouses over the map.
There was a problem hiding this comment.
My thoughts on this are that I don't think that this is behaving any differently than angular's native mousemove event, which does cause change detection every time, and makes the user handle it, either by using OnPush or by manually having them run events outside of the Angular zone. My preference would be to do the same, especially since I can imagine a situation where someone has a simple app where they do want change detection to run every time (such as displaying the current lat/lng of the mouse cursor).
Add support for Google Maps event handlers, properties, and methods to the Google Map component, including click handlers, methods to pan with the map and access to the controls and data properties.
Change event names so they will not collide with native angular events.
Add jsdoc and comments to new events, methods, and properties.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add support for Google Maps event handlers, properties, and methods to
the Google Map component, including click handlers, methods to pan with
the map and access to the controls and data properties.