fix(material-experimental/chips): high contrast mode fixes #16811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues with the MDC-based chips in high contrast mode: * Chips blending in with the background because they don't have an outline or a border. * No focus indication being visible. * Chips being hidden completely on hover because we were using an RGBA overlay.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 19, 2019
|
|
||
| // Note that we use a `background` and `opacity`, instead of an `rgba` background, because | ||
| // `rgba` backgrounds get converted into solid colors in high contrast mode. | ||
| background: #000; |
There was a problem hiding this comment.
I went with this since it's shorter.
That would be great! Thanks .. |
|
FWIW some of the changes here target the hover indication that we implemented ourselves because we aren't using the MDC ripples. |
jelbourn
approved these changes
Aug 19, 2019
jelbourn
added
pr: lgtm
action: merge
|
(not merge-safe since the chips are actually used by one team now) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with the MDC-based chips in high contrast mode: