build: workaround for dev-app livereloading with ibazel #16882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a workaround that makes livereloading work most of the time. It won't work if the default port for the ibazel livereloading script has changed. This can happen if the port is already used/reserved or if the default port changes in the `livereload-server` implementation. Ideally the livereloading script would be served from a canonical location that always works (regardless of the port). A proposal for this has been submitted within: bazelbuild/rules_typescript#468
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Aug 27, 2019
Adds a workaround that makes livereloading work most of the time. It won't work if the default port for the ibazel livereloading script has changed. This can happen if the port is already used/reserved or if the default port changes in the `livereload-server` implementation. Ideally the livereloading script would be served from a canonical location that always works (regardless of the port). A proposal for this has been submitted within: bazelbuild/rules_typescript#468
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workaround that makes livereloading work most of the time. It won't
work if the default port for the ibazel livereloading script has changed. This
can happen if the port is already used/reserved or if the default port changes
in the
livereload-serverimplementation.Ideally the livereloading script would be served from a canonical location
that always works (regardless of the port). A proposal for this has been
submitted within: bazelbuild/rules_typescript#468