build: bump yarn requirement to 1.17.3 #16890
Conversation
googlebot
added
the
cla: yes
josephperrott
force-pushed
the
yarn-fix
branch
from
a0982b0 to
c078c3f
Compare
josephperrott
force-pushed
the
yarn-fix
branch
9 times, most recently
from
612a0df to
bb2bcfd
Compare
.circleci/config.yml
Outdated
| @@ -351,8 +316,6 @@ jobs: | |||
| - *attach_release_output | |||
| - *setup_bazel_ci_config | |||
| - *setup_bazel_remote_execution | |||
| - *yarn_download | |||
| - *yarn_install | |||
| - *setup_bazel_binary | |||
There was a problem hiding this comment.
we actually need the yarn download and yarn install here as we need to download bazel through yarn.
Afterwards it will be linked globally using the setup_bazel_binary.
There was a problem hiding this comment.
Yeah, I was really thrown off and then I realized that yarn_install was run yarn install not install yarn...
I'm not thinking clearly this morning evidently.
There was a problem hiding this comment.
haha no worries 😄 can you elaborate why we want to remove yarn_download though?
The reason we have this is that we can control the yarn version better without having to depend on a specific version coupled with the Docker image. We did the same on angular/angular for that reason.
There was a problem hiding this comment.
We can go back to that if that is our reasoning. I was under the impression we did it so we could install a yarn version that was beyond was was in the Docker image. But since the Docker image is providing the latest yarn I was thinking we would just move to that.
But if we want to control it as we were we can.
There was a problem hiding this comment.
Yeah, I'd vote for keeping it like that to still have the flexibility. Up to you though. I don't feel too strong about it, but IIRC we already had a discussion about this and decided to download Yarn separately.
josephperrott
force-pushed
the
yarn-fix
branch
3 times, most recently
from
03e342d to
c847b9d
Compare
josephperrott
force-pushed
the
yarn-fix
branch
from
c847b9d to
14c0269
Compare
josephperrott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.