feat(youtube-player): Add documentation to the README #16925
Conversation
googlebot
added
the
cla: yes
YourDeveloperFriend
force-pushed
the
documentation
branch
from
1a895bb to
9f11065
Compare
src/youtube-player/README.md
Outdated
| onInit() { | ||
| // This code loads the IFrame Player API code asynchronously, according to the instructions at | ||
| // https://developers.google.com/youtube/iframe_api_reference#Getting_Started | ||
| var tag = document.createElement('script'); |
There was a problem hiding this comment.
Also if somebody took this example verbatim, wouldn't they get a new script tag for every time the user visits a page? Couldn't we somehow handle this for the consumer from inside the YouTube player package?
There was a problem hiding this comment.
Also if somebody took this example verbatim, wouldn't they get a new script tag for every time the user visits a page?
They would get a new script tag for every instance of this example component that they inject.
Couldn't we somehow handle this for the consumer from inside the YouTube player package?
The problem is that this is not necessarily the technique that the user would use to inject the script into their page. They could bundle the script into their binary, or download it via npm.
If we try to resolve this problem on their behalf, we then have to figure out whether or not the script has already been loaded, which is impossible if it's in the process of loading and hasn't loaded yet. This would require some kind of inter-component coordination, probably through a service. Anyways, it's certainly an option.
YourDeveloperFriend
force-pushed
the
documentation
branch
2 times, most recently
from
373d6fa to
8c7ece9
Compare
YourDeveloperFriend
force-pushed
the
documentation
branch
from
8c7ece9 to
f5e4b3b
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.