Skip to content

build: fix compilation error in dialog harness #16928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

build: fix compilation error in dialog harness #16928

merged 1 commit into from
Sep 3, 2019

Conversation

crisbeto
Copy link
Member

Fixes an error due to a couple of PRs getting merged in out of sequence.

@crisbeto crisbeto self-assigned this Aug 31, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 31, 2019
@crisbeto
build: fix compilation error in dialog harness
a499463 
Fixes an error due to a couple of PRs getting merged in out of sequence.
@crisbeto crisbeto force-pushed the dialog-harness-error branch from 2d8b004 to a499463 Compare August 31, 2019 07:35
This was referenced Aug 31, 2019
Closed
Merged
@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 31, 2019
@crisbeto crisbeto marked this pull request as ready for review August 31, 2019 07:42
@crisbeto crisbeto requested a review from devversion as a code owner August 31, 2019 07:42
@crisbeto crisbeto assigned jelbourn and mmalerba and unassigned crisbeto Aug 31, 2019
devversion
devversion approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 31, 2019
@devversion devversion mentioned this pull request Sep 1, 2019
Merged
jelbourn
jelbourn approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1ec2d9e into angular:master Sep 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @mmalerba