Skip to content

refactor(form-field): remove unnecessary bindings #16941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

refactor(form-field): remove unnecessary bindings #16941

merged 1 commit into from
Apr 8, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 1, 2019

Removes the mat-accent and mat-warn host bindings from the mat-form-field since they're already handled by the Color mixin.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Sep 1, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner September 1, 2019 14:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2019
@crisbeto
refactor(form-field): remove unnecessary bindings
9250c8d 
Removes the `mat-accent` and `mat-warn` host bindings from the `mat-form-field` since they're already handled by the `Color` mixin.
@crisbeto crisbeto force-pushed the form-field-unnecessary-bindings branch from 83d2c0c to 9250c8d Compare September 8, 2019 15:27
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 9, 2019
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba mmalerba merged commit 0f739db into angular:master Apr 8, 2021
mmalerba pushed a commit that referenced this pull request Apr 8, 2021
@crisbeto @mmalerba
refactor(form-field): remove unnecessary bindings (#16941)
9aa3a26 
Removes the `mat-accent` and `mat-warn` host bindings from the `mat-form-field` since they're already handled by the `Color` mixin.

(cherry picked from commit 0f739db)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @googlebot @mmalerba