Skip to content

build: convert prerender gulp task to bazel #16943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Since 57e31da landed a few days ago, we can finally convert the prerender gulp task to Bazel and also verify that tsickle runs properly.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 2, 2019
@devversion devversion requested review from jelbourn and a team as code owners September 2, 2019 09:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2019
@devversion devversion force-pushed the build/replace-pre-render-gulp-task-with-bazel branch from 7e27025 to 4f0b1ab Compare September 2, 2019 09:44
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do any verification before that we are able to build it?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 3, 2019
@ngbot
Copy link

ngbot bot commented Sep 3, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: bazel_build" is failing
    failure status "ci/circleci: ivy_test" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion force-pushed the build/replace-pre-render-gulp-task-with-bazel branch from 4f0b1ab to ed02ddb Compare September 3, 2019 19:37
@jelbourn jelbourn merged commit ce71a45 into angular:master Sep 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants