Skip to content

build: add more linting around async/await #16976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2019
Merged

build: add more linting around async/await #16976

merged 1 commit into from
Sep 5, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 4, 2019 •
edited
Loading

Given that we'll be using async/await a lot more because of the test harnesses, these changes enable the await-promise rule which ensures that the value that is being await-ed is a promise.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 4, 2019
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 4, 2019
@crisbeto crisbeto marked this pull request as ready for review September 4, 2019 20:44
@crisbeto crisbeto requested review from jelbourn, mmalerba and a team as code owners September 4, 2019 20:44
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Sep 4, 2019
mmalerba
mmalerba reviewed Sep 4, 2019
View reviewed changes
devversion
devversion approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just Miles' comment. I don't feel strong about it. I personally also liked just being able to throw.

@jelbourn
Copy link
Member

jelbourn commented Sep 4, 2019

Let's discuss at the team meeting

@crisbeto
build: add more linting around async/await
2a24c7f 
Given that we'll be using async/await a lot more because of the test harnesses, these changes enable the `await-promise` rule which ensures that the value that is being `await`-ed is a promise.
@crisbeto crisbeto force-pushed the async-await-linting branch from 426f2ab to 2a24c7f Compare September 5, 2019 19:48
@crisbeto
Copy link
Member Author

crisbeto commented Sep 5, 2019

Reworked based on our discussion @mmalerba @jelbourn.

jelbourn
jelbourn approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: lgtm labels Sep 5, 2019
@jelbourn jelbourn merged commit cd0611d into angular:master Sep 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @mmalerba @googlebot